remove recursion from VMInputStream #2816
Conversation
Can you give numbers for this overhead? |
|
I did some testing. If the build is successful no recursive calls happen. Only if something is written to the |
What's wrong with that? When you said "overhead" I was expecting some time measurements... a recursive call is not overhead per se. |
|
I agree. I was also expecting different results. I got here in the first place due to a exception with a large stacktrace |
| return read(); | ||
| } | ||
| throw e; | ||
| while (true) { |
There was a problem hiding this comment.
So this would be an endless loop instead of Stackoverflow? Doesn't sound better, but yes the recursion seems wrong too.
What it does
Currently
VMInputStreamuses recursion to retry reads in theint read()method. I replaced the recursive call with a while loop. This removes unnecessary overhead while running tests.How to test
This doesn't change any behavior.
Author checklist